Skip to content

chore(build): migrate to golangci-lint@v2 and golangci-lint-action@v7 #1163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025

Conversation

xcoulon
Copy link
Contributor

@xcoulon xcoulon commented Mar 27, 2025

upgraded .golangci.yml with golangci-lint migrate

include fixes suggested by golangci-lint run -c ./.golangci.yml

Signed-off-by: Xavier Coulon xcoulon@redhat.com

upgraded `.golangci.yml` with `golangci-lint migrate`

include fixes suggested by `golangci-lint run -c ./.golangci.yml`

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
Copy link

@xcoulon
Copy link
Contributor Author

xcoulon commented Mar 27, 2025

/test e2e

Copy link

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MatousJobanek, metlos, xcoulon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [MatousJobanek,metlos,xcoulon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xcoulon xcoulon merged commit f88d814 into codeready-toolchain:master Mar 27, 2025
12 of 14 checks passed
@xcoulon xcoulon deleted the golangci_2_host_operator branch March 27, 2025 16:18
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (859739a) to head (b16ad65).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controllers/socialevent/socialevent_controller.go 60.00% 0 Missing and 2 partials ⚠️
test/configmap_assertions.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   83.74%   83.76%   +0.02%     
==========================================
  Files          82       82              
  Lines        7931     7929       -2     
==========================================
  Hits         6642     6642              
+ Misses       1092     1090       -2     
  Partials      197      197              
Files with missing lines Coverage Δ
...ontrollers/deactivation/deactivation_controller.go 81.38% <100.00%> (ø)
...ebindingcleanup/spacebinding_cleanup_controller.go 77.51% <100.00%> (ø)
...cebindingrequest/spacebindingrequest_controller.go 84.47% <100.00%> (ø)
...ontrollers/spacerequest/spacerequest_controller.go 87.79% <100.00%> (ø)
controllers/usersignup/predicate.go 80.00% <ø> (+3.80%) ⬆️
...usersignupcleanup/usersignup_cleanup_controller.go 76.47% <100.00%> (ø)
...es/notificationtemplates/notification_generator.go 80.64% <100.00%> (ø)
pkg/templates/usertiers/usertier_generator.go 78.19% <100.00%> (ø)
test/cluster.go 64.70% <100.00%> (ø)
test/configmap_assertions.go 0.00% <0.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants